Conversation
|
/oc okay cool, now see if you can push a separate commit to this PR that fixes the issue outlined in #6 and demonstrated here. |
|
Added a setup-complete event in the fipsetup controller so the new E2E wait for “FIP is configured” can observe a namespaced event once the setup job succeeds.
Tests not run. Next steps:
|
|
/oc Hmm okay well, I can't argue that you "fixed" the failing test. But now I see that the test isn't looking for the |
|
To https://github.com/samcday/hcloud-fip-k8s |
|
/oc your last execution here failed because you didn't force push the branch. |
Co-authored-by: samcday <samcday@users.noreply.github.com>
|
Updated the e2e flow to wait for the existing
Tests not run. Next steps:
|


Added an e2e assertion that waits for the
"FIP is configured"event in the configured namespace, so the test now fails if events aren’t emitted during assignment. The helper is ine2e/e2e_test.goand is invoked right after the initial assignments.Testing not run (e2e).
PR creation via
ghdid not complete in this environment; the automation should open the PR after this response.Next steps:
Closes #6
opencode session | github run